Fix logic handling primitive wrapper in URL params #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ESP, wrapped primitives in URL can also be parsed from seralized string format of the primitive directly without ".value" field reference. This PR changes URL parsing logic to conform with this behavior.
|
Weird, the cla/google check get stuck again ... |
|
Congratulations! Your PR was the one that allowed us to figure out why it gets stuck. I think it shouldn't have that problem any more... WOO! |
|
Wow that was super fast! Thanks!! |
|
TBH I'm sorry it took this long. I looked at it last night and wanted to merge it then but you hadn't commented yet to tickle the CLA bot. Hopefully this will not be a problem going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ESP, wrapped primitives in URL can also be parsed from seralized
string format of the primitive directly without ".value" field
reference. This PR changes URL parsing logic to conform with this
behavior.