Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grpc.WithInsecure() as option for grpc.Dial call in template #52

Merged
merged 1 commit into from
Sep 15, 2015
Merged

add grpc.WithInsecure() as option for grpc.Dial call in template #52

merged 1 commit into from
Sep 15, 2015

Conversation

bufdev
Copy link
Contributor

@bufdev bufdev commented Sep 15, 2015

This has been needed for a little bit from grpc/grpc-go@996538a, right now the FromEndpoint functions will not work without this.

@bufdev
Copy link
Contributor Author

bufdev commented Sep 15, 2015

I'm not sure on the Travis build failure - advise?

@yugui
Copy link
Member

yugui commented Sep 15, 2015

I have restarted the tests. I expect it will success since I have merged #51.

@yugui
Copy link
Member

yugui commented Sep 15, 2015

LGTM

@bufdev
Copy link
Contributor Author

bufdev commented Sep 15, 2015

Note I'll have to merge the other two open PRs I submitted after this is
merged, but they can still be reviewed.

On Monday, September 14, 2015, Yuki Yugui Sonoda [email protected]
wrote:

LGTM


Reply to this email directly or view it on GitHub
#52 (comment).

yugui added a commit that referenced this pull request Sep 15, 2015
add grpc.WithInsecure() as option for grpc.Dial call in template
@yugui yugui merged commit 43f22ab into grpc-ecosystem:master Sep 15, 2015
ithinker1991 pushed a commit to tronprotocol/grpc-gateway that referenced this pull request May 27, 2018
…-from-solidityNode

remove listaccounts from WalletSolidity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants