fix noenc error by fixing Details error field #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As advised by @itizir in the discussion of grpc-ecosystem#551. However, I've gone with the minimal change to make the error go away, I haven't introduced a proper, generated protobuf definition. Also, I've noticed our error body message there looks suspiciously like Status[1], except for the field name "Error" vs "Message". Fixes grpc-ecosystem#551. [1]: https://github.com/google/go-genproto/blob/2b5a72b8730b0b/googleapis/rpc/status/status.pb.go#L83-L93 Signed-off-by: Stephan Renatus <[email protected]>
In that PR we decided to not include the complete proto. Turns out it is comically large and dramatically increases the complexity of vendoring making it kind of a logistical nightmare. Thanks for sending in the PR! |
|
@achew22 thanks for sharing your rationale :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As advised by @itizir in the discussion of #551.
However, I've gone with the minimal change to make the error go away, I
haven't introduced a proper, generated protobuf definition.
Also, I've noticed our error body message there looks suspiciously like
Status, except for the field name "Error" vs "Message".
Fixes #551.