Support param for field from Oneof definition. #621
Conversation
There was a problem hiding this comment.
Thank you for your great contribution. Almost LGTM except minor comments.
- comments about error messages
- unused proto field
- Could you regenerate files in
example/...bymake examples?
File integrity check seems to be failing on TravisCI. https://travis-ci.org/grpc-ecosystem/grpc-gateway/jobs/371495622#L712
| return | ||
| } | ||
| if got, want := msg.GetStatus().GetNote(), "golang"; got != want { | ||
| t.Errorf("msg.Lang = %q; want %q", got, want) |
There was a problem hiding this comment.
"msg.GetStaus().GetNote() = %q; want %q".
| return | ||
| } | ||
| if got, want := msg.GetNo().GetNote(), "golang"; got != want { | ||
| t.Errorf("msg.Lang = %q; want %q", got, want) |
There was a problem hiding this comment.
"msg.GetNo().GetNote() = %q; want %q"
| int64 line_num = 3; | ||
| string lang = 4; | ||
| } | ||
| int64 time = 5; |
There was a problem hiding this comment.
Can you remove time if you are not using it?
I'd like to keep SimpleMessage as simple as possible.
|
I didn't know those files need be regenerated and reason of build failure. |
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 59.12% 58.88% -0.25%
==========================================
Files 30 30
Lines 2838 2853 +15
==========================================
+ Hits 1678 1680 +2
- Misses 998 1010 +12
- Partials 162 163 +1
Continue to review full report at Codecov.
|
|
LGTM. Thank you for your contribution. |
* Support param for field from Oneof definition. * Fix error reason and regenerate files. * Regenerate echo_service.pb.gw.go.
when the param binds with a field defined by Oneof, it can not be assigned directly.