-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a single swagger definition on demand #658
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
6ae6013
to
e7b79eb
Compare
I manually edited both changes to leave authorship with their respective author, rebased and uploaded. This can now fix a long standing issue. Thanks so much everyone! |
@achew22 any idea when this might be released? Would it make 1.4.x? |
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
- Coverage 58.94% 57.78% -1.16%
==========================================
Files 30 30
Lines 2857 2914 +57
==========================================
Hits 1684 1684
- Misses 1010 1066 +56
- Partials 163 164 +1
Continue to review full report at Codecov.
|
@hexfusion ask and you shall receive https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v1.4.1 |
Perfect thanks a lot! |
Combines the efforts of @cy-zheng in #643 with the efforts of @zxy198717 in #591.
Fixes: #643, #591, #99