Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PascalFromSnake behavior #85

Merged
merged 3 commits into from
Jan 6, 2016

Conversation

tmc
Copy link
Collaborator

@tmc tmc commented Jan 6, 2016

Fixes #84 (and doesn't bring in new dependency)

for _, c := range strings.Split(str, "_") {
components = append(components, strings.Title(strings.ToLower(c)))
func PascalFromSnake(s string) string {
// adopted from github.com/golang/protobuf/protoc-gen-go/generator/generator.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the following copyright notice as a comment just after this line?

// Copyright 2010 The Go Authors.  All rights reserved.
// https://github.com/golang/protobuf
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
//     * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
//     * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
//     * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

@yugui
Copy link
Member

yugui commented Jan 6, 2016

Thank you for your contribution.
LGTM as a short-term solution except the license issue I commented above.

For mid-term, it might be better to generate static mapping between proto field names and go field names because the only runtime usage of PascalFromSnake is in runtime/query.go. So once we have the static mapping for runtime usage, we can safely depend on "github.com/golang/protobuf/protoc-gen-go/generator".CamelCase.

The test failure in Travis CI is caused because generated files in the repository are out-of-date. So you can ignore the failure for now.

@tmc
Copy link
Collaborator Author

tmc commented Jan 6, 2016

@yugui I like that solution for the mid-term.

@yugui
Copy link
Member

yugui commented Jan 6, 2016

LGTM

yugui added a commit that referenced this pull request Jan 6, 2016
@yugui yugui merged commit f647940 into grpc-ecosystem:master Jan 6, 2016
@yugui
Copy link
Member

yugui commented Jan 6, 2016

Thank you!

yugui added a commit that referenced this pull request Jan 28, 2016
Use the metadata proto.GetProperty returns instead.

Since the conversion rule is getting complicated, it is hard to emulate
the rule. c.f. #85
yugui added a commit that referenced this pull request Jan 28, 2016
Use the metadata proto.GetProperty returns instead.

Since the conversion rule is getting complicated, it is hard to emulate
the rule. c.f. #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants