comments (on comments)

balancer/grpclb/grpclb.go

@@ -426,7 +426,7 @@ func (lb *lbBalancer) UpdateClientConnState(ccs balancer.ClientConnState) error
 
 	addrs := ccs.ResolverState.Addresses
 	if len(addrs) == 0 {
-		// There's should be at least one address, either grpclb server or
+		// There should be at least one address, either grpclb server or
 		// fallback. Empty address is not valid.
 		return balancer.ErrBadResolverState
 	}

balancer/grpclb/grpclb_remote_balancer.go

@@ -241,11 +241,10 @@ func (lb *lbBalancer) newRemoteBalancerCCWrapper() {
 		PermitWithoutStream: true,
 	}))
 
-	// DialContext using manualResolver.Scheme, which is a random scheme
-	// generated when init grpclb. The target scheme here is not important.
+	// The dial target is not important.
 	//
-	// The grpc dial target will be used by the creds (ALTS) as the authority,
-	// so it has to be set to remoteLBName that comes from resolver.
+	// The grpclb server addresses will set field ServerName, and creds will
+	// receive ServerName as authority.
 	cc, err := grpc.DialContext(context.Background(), "grpclb.subClientConn", dopts...)
 	if err != nil {
 		grpclog.Fatalf("failed to dial: %v", err)

balancer/grpclb/grpclb_test.go

@@ -91,7 +91,7 @@ func (c *serverNameCheckCreds) ClientHandshake(ctx context.Context, authority st
 	}
 	if authority != string(b) {
 		fmt.Printf("test-creds: got authority from ClientConn %q, expected by server %q\n", authority, string(b))
-		return nil, nil, errors.New("received unexpected server nameq")
+		return nil, nil, errors.New("received unexpected server name")
 	}
 	return rawConn, nil, nil
 }