Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials/oauth: Distinguish between Unavailable and Unauthenticated errors #1704

Closed
dfawley opened this issue Nov 30, 2017 · 1 comment
Closed

Comments

@dfawley
Copy link
Member

dfawley commented Nov 30, 2017

See grpc/grpc-java#3267 (comment) for more information.

The fix is here:

data, err := c.GetRequestMetadata(ctx, audience)
if err != nil {
return nil, streamErrorf(codes.Internal, "transport: %v", err)
}

This should respect any status codes returned by the PerRPCCredentials call, and use UNAUTHENTICATED if one is not returned (instead of INTERNAL). The oauth implementation should return UNAVAILABLE if the oauth server cannot be reached.

jeanbza added a commit to jeanbza/grpc-go that referenced this issue Dec 31, 2017
jeanbza added a commit to jeanbza/grpc-go that referenced this issue Dec 31, 2017
jeanbza added a commit to jeanbza/grpc-go that referenced this issue Jan 3, 2018
@dfawley dfawley changed the title Return UNAVAILABLE and UNAUTHENTICATED statuses from PerRPCCredential errors credentials/oauth: Distinguish between Unavailable and Unauthenticated errors Jan 3, 2018
@dfawley
Copy link
Member Author

dfawley commented May 3, 2021

This has been blocked for 3 years, so I'm just going to close it. If anything happens on golang/oauth2#264, we can reopen this or file a new copy.

@dfawley dfawley closed this as completed May 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant