Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose http SETTINGS_HEADER_TABLE_SIZE option to user #2910

Closed
MoZhonghua opened this issue Jul 17, 2019 · 1 comment · Fixed by #2931
Closed

expose http SETTINGS_HEADER_TABLE_SIZE option to user #2910

MoZhonghua opened this issue Jul 17, 2019 · 1 comment · Fixed by #2931
Labels
P2 Type: Feature New features or improvements in behavior

Comments

@MoZhonghua
Copy link
Contributor

Please see the FAQ in our main README.md before submitting your issue.

Use case(s) - what problem will this feature solve?

We want to copy grpc stream from product enviroment to test enviroment using libpcap:

  1. capture packet using libpcap
  2. parse http2 frame and extract grpc request data
  3. forward this request data to test environment

This is almost impossbile if http2 uses a dynamic header table for following reasons:

  • we must capture full tcp stream from first packet
  • we must NOT lost any packet of, or the dynamic tables will mismatch

Proposed Solution

We already has http2 settings related options, such as MaxHeaderListSize.
Just add an new grpc server option to disable dynamic header table, so we can disable
http2 dynamic header by setting SETTINGS_HEADER_TABLE_SIZE to 0.

We will send more data for requests in product env, less than 150 bytes for each requests in
our environment. This is ok for us because we only disable dynamic header table when we
need copy stream.

Alternatives Considered

Additional Context

@MoZhonghua MoZhonghua added the Type: Feature New features or improvements in behavior label Jul 17, 2019
MoZhonghua added a commit to MoZhonghua/grpc-go that referenced this issue Jul 24, 2019
@menghanl menghanl added the P2 label Aug 8, 2019
@stale
Copy link

stale bot commented Sep 6, 2019

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@stale stale bot added the stale label Sep 6, 2019
@dfawley dfawley removed the stale label Sep 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants