-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include idempotency level in UnaryServerInfo #1634
Include idempotency level in UnaryServerInfo #1634
Conversation
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can you explain a bit more on the purpose of this change? |
Protoc now supports an
The purpose of the change is to include this |
CLAs look good, thanks! |
I signed it! |
Thanks for the PR. We would prefer to implement this by making the entire proto file descriptor available to interceptors, which would include this information. (#1526) Unfortunately, that requires changes to generated code, which means it's blocked on us (this PR would have the same constraint). We hope to get to this early next quarter. Please let us know if you have any concerns with this. |
Adding idempotency level information to the
UnaryServerInfo
allows idempotency level to be used in server interceptors.