-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: set TCP_USER_TIMEOUT socket option for linux #2307
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4e1bbac
set TCP_USER_TIMEOUT socketopt
mikeraimondi 3cfab97
clean up error messages
mikeraimondi 44836e0
move function to syscall
mikeraimondi ab5224a
move keepaliveEnabled check and SetTCPUserTimeout before handshake
mikeraimondi a5123f8
exit early unless conn is TCP
mikeraimondi 6698359
Merge remote-tracking branch 'upstream/master' into set_tcp_user_timeout
mikeraimondi 60d7792
switch from File() to SyscallConn() and add test
mikeraimondi e888557
use negative value instead of error to indicate unsupported env
mikeraimondi 8581840
use 'setUpWithOptions' so server-side logic is correctly handled
mikeraimondi 0c1e11e
Merge remote-tracking branch 'upstream/master' into set_tcp_user_timeout
mikeraimondi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should only need to make the listener once, right (i.e. outside the loop)?
You also never call
lis.Accept()
, which seems like it should be necessary. You would also need to read from theconn
on the server side, because the client writes its 24-byte preface before returning (we think this is the cause of a separate test flake we're having).