-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolver: Add new fields to resolver.BuildOption struct to support dialing a remote name resolver #3098
Conversation
@dfawley |
Can you update this PR so that it also sets all the fields? Or was this PR intended to be a proposal / strawman for discussion purposes? |
I was initially being lazy and thought I'd do that with the xdsResolver changes. But makes sense to do it here. Done. |
These fields will be used by resolver implementations which need to talk to a remote name resolver.
Ping ... |
resolver/resolver.go
Outdated
DisableServiceConfig bool | ||
// DialCreds is the transport credentials that a resolver implementation | ||
// can use to dial a remote name resolution server. Resolver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should say simply that it's the DialCreds for the ClientConn? It may not be appropriate to use these credentials for your name resolver in many (practically all?) cases. Same for the other two fields, except that a Bundle is a little more likely to be OK to use. Possibly include a warning about using this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this sound OK? If so, I can make similar modifications to the other two fields as well.
DialCreds is the transport credentials used by the ClientConn (set as a DialOption
using a call to WithTransportCredentials) while communicating with the gRPC
server. In some cases, it may be appropriate for a resolver implementation to use
these credentials to talk to a remote name resolution server. In most cases though,
it might not be appropriate and should be used with caution.
How about:
|
Done. Thanks. |
These fields will be used by resolver implementations which need to talk
to a remote name resolver.