change grpclog to use structured logging #322
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at changing all the log sites to use structured logging, with a pluggable interface. I didn't want to pull existing implementations (like logrus or go-kit/log) to avoid adding dependencies. There are many places, like in tests, where
grpclog
was used and I think a better use would be to pass around atesting.TB
handle, but I didn't do that change to avoid mixing concerns in 1 PR.Relates to #289.
I signed the CLA.