Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authz: update representation of allow authenticated in SDK #5052

Merged
merged 4 commits into from
Dec 28, 2021
Merged

authz: update representation of allow authenticated in SDK #5052

merged 4 commits into from
Dec 28, 2021

Conversation

ashithasantosh
Copy link
Contributor

@ashithasantosh ashithasantosh commented Dec 10, 2021 •
edited
Loading

With the changes in this PR, allow authenticated can be represented using principals: ["*", ""] instead of principals: [].
This way we can avoid special semantics.

Related discussion
grpc/proposal#246 (comment)

RELEASE NOTES:

  • authz: update representation of allow authenticated in SDK

@ashithasantosh ashithasantosh marked this pull request as draft December 10, 2021 07:42
@ashithasantosh ashithasantosh added this to the 1.44 Release milestone Dec 14, 2021
@ashithasantosh ashithasantosh marked this pull request as ready for review December 14, 2021 00:38
@easwars easwars self-assigned this Dec 15, 2021
easwars
easwars reviewed Dec 21, 2021
View reviewed changes
authz/rbac_translator.go Outdated Show resolved Hide resolved
authz/sdk_end2end_test.go Show resolved Hide resolved
authz/rbac_translator_test.go Show resolved Hide resolved
@easwars easwars assigned ashithasantosh and unassigned easwars Dec 21, 2021
@easwars
Copy link
Contributor

easwars commented Dec 21, 2021

@zasweq

@ashithasantosh
Copy link
Contributor Author

Thank you for the review!:)

@ashithasantosh ashithasantosh merged commit fbaf7c5 into grpc:master Dec 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

@dfawley dfawley Awaiting requested review from dfawley

Assignees

@ashithasantosh ashithasantosh

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.44 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ashithasantosh @easwars