Add logrus, log15, lion as internal options for grpclog #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Edge <[email protected]>
Signed-off-by: Peter Edge <[email protected]>
|
Squash these commits into one. We don't need to see typo fixes in the git history. Also, you're right that this shouldn't introduce a dependency. Especially a dependency just for an interface. An interface can be defined locally if needed. And this interface is too large and not stable. It's marked experimental. I don't think we want this. Let's identify the problem before we jump to a solution. Please close this PR and let's discuss on a bug, if there's not already one open. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Edge [email protected]
I'm not sure if this violates the no-external-dependencies requirement, but thought I would send this over as it might help some others. We're also discussing grpclog for grpc-gateway in grpc-ecosystem/grpc-gateway#92, and this would add a couple more packages.
Modeled after https://go.pedge.io/dlog