log error message and source address in handshake error #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamqizhao
added a commit
that referenced
this pull request
Feb 24, 2016
log error message and source address in handshake error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using gRPC with TLS Certificate Authentication. The default log messages are very hard to understand what went wrong. Currently, you get:
2016/02/23 11:01:59 grpc: Server.Serve failed to complete security handshake.This PR changes the logged message to something like this:
2016/02/23 11:08:57 grpc: Server.Serve failed to complete security handshake from "127.0.0.1:49423": tls: failed to verify client's certificate: x509: certificate signed by unknown authorityImproving the interface with Context (#547) is nice and I would love structed logging (#289), today it is very difficult to debug basic TLS client authentication issues -- all the client sees is a TLS alert for
bad certificatein this case, so having the server log anything more is very helpful.