Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: performance improvements #588

Merged
merged 1 commit into from
Mar 29, 2016
Merged

transport: performance improvements #588

merged 1 commit into from
Mar 29, 2016

Commits on Mar 29, 2016

  1. transport: skip the backlog if it's empty 

    This provides a modest reduction in allocation count.

Benchmarked using https://github.com/cockroachdb/rpc-bench:

```
name                 old time/op    new time/op    delta
GRPCServeHTTP_1K-4      181µs ± 3%     178µs ± 2%    ~     (p=0.310 n=5+5)
GRPCServeHTTP_64K-4    1.31ms ± 4%    1.30ms ± 3%    ~     (p=0.548 n=5+5)

name                 old speed      new speed      delta
GRPCServeHTTP_1K-4   11.3MB/s ± 3%  11.5MB/s ± 2%    ~     (p=0.246 n=5+5)
GRPCServeHTTP_64K-4   100MB/s ± 4%   100MB/s ± 2%    ~     (p=0.548 n=5+5)

name                 old alloc/op   new alloc/op   delta
GRPCServeHTTP_1K-4     88.5kB ± 0%    88.5kB ± 0%  -0.09%  (p=0.008 n=5+5)
GRPCServeHTTP_64K-4     801kB ± 0%     801kB ± 0%  -0.05%  (p=0.008 n=5+5)

name                 old allocs/op  new allocs/op  delta
GRPCServeHTTP_1K-4        167 ± 0%       162 ± 0%  -2.99%  (p=0.008 n=5+5)
GRPCServeHTTP_64K-4       672 ± 0%       645 ± 0%  -4.08%  (p=0.008 n=5+5)
```
    @tamird
    tamird committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    54ac757 View commit details
    Browse the repository at this point in the history