Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.*: fix revive lint issues unused-parameter #7580

Merged
merged 13 commits into from
Sep 3, 2024
Merged

.*: fix revive lint issues unused-parameter #7580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ed434dc
Fixed linter issues for superfluous-else, increment-decrement, indent…
janardhanvissa Aug 14, 2024
3ea5488
Reverting context-as-argument in server.go
janardhanvissa Aug 14, 2024
7beda74
Merge pull request #1 from janardhanvissa/linter-godoc
janardhanvissa Aug 18, 2024
bd44787
Revert "Optimising the code by fixing var-declaration, indent-error-f…
janardhanvissa Aug 18, 2024
c3dfaaf
Merge pull request #4 from janardhanvissa/revert-1-linter-godoc
janardhanvissa Aug 18, 2024
932ed9f
Merge branch 'grpc:master' into master
janardhanvissa Aug 22, 2024
023be1f
Merge branch 'grpc:master' into master
janardhanvissa Aug 22, 2024
37f7a6b
Merge branch 'grpc:master' into master
janardhanvissa Aug 26, 2024
dfeb468
Merge branch 'grpc:master' into master
janardhanvissa Aug 29, 2024
1a64983
Merge branch 'grpc:master' into master
janardhanvissa Aug 31, 2024
184ba0f
Fix revive linter: unused-parameter
janardhanvissa Aug 31, 2024
dd2c482
Fix revive linter: unused-parameter
janardhanvissa Aug 31, 2024
3c606f1
re-trigger
janardhanvissa Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion credentials/alts/alts_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ type testServer struct {
testgrpc.UnimplementedTestServiceServer
}

func (s *testServer) UnaryCall(ctx context.Context, in *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
func (s *testServer) UnaryCall(_ context.Context, _ *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
return &testpb.SimpleResponse{
Payload: &testpb.Payload{},
}, nil
Expand Down
2 changes: 1 addition & 1 deletion examples/features/unix_abstract/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type ecServer struct {
addr string
}

func (s *ecServer) UnaryEcho(ctx context.Context, req *pb.EchoRequest) (*pb.EchoResponse, error) {
func (s *ecServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.EchoResponse, error) {
return &pb.EchoResponse{Message: fmt.Sprintf("%s (from %s)", req.Message, s.addr)}, nil
}

Expand Down
19 changes: 10 additions & 9 deletions gcp/observability/logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ func (s) TestBothClientAndServerRPCEvents(t *testing.T) {
defer cleanup()

ss := &stubserver.StubServer{
UnaryCallF: func(ctx context.Context, in *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
UnaryCallF: func(_ context.Context, _ *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
return &testpb.SimpleResponse{}, nil
},
FullDuplexCallF: func(stream testgrpc.TestService_FullDuplexCallServer) error {
Expand Down Expand Up @@ -650,7 +650,7 @@ func (s) TestClientRPCEventsTruncateHeaderAndMetadata(t *testing.T) {
newLoggingExporter = ne
}(newLoggingExporter)

newLoggingExporter = func(ctx context.Context, config *config) (loggingExporter, error) {
newLoggingExporter = func(_ context.Context, _ *config) (loggingExporter, error) {
return fle, nil
}

Expand All @@ -673,7 +673,7 @@ func (s) TestClientRPCEventsTruncateHeaderAndMetadata(t *testing.T) {
defer cleanup()

ss := &stubserver.StubServer{
UnaryCallF: func(ctx context.Context, in *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
UnaryCallF: func(_ context.Context, _ *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
return &testpb.SimpleResponse{}, nil
},
}
Expand Down Expand Up @@ -787,7 +787,7 @@ func (s) TestPrecedenceOrderingInConfiguration(t *testing.T) {
newLoggingExporter = ne
}(newLoggingExporter)

newLoggingExporter = func(ctx context.Context, config *config) (loggingExporter, error) {
newLoggingExporter = func(_ context.Context, _ *config) (loggingExporter, error) {
return fle, nil
}

Expand Down Expand Up @@ -822,10 +822,10 @@ func (s) TestPrecedenceOrderingInConfiguration(t *testing.T) {
defer cleanup()

ss := &stubserver.StubServer{
EmptyCallF: func(ctx context.Context, in *testpb.Empty) (*testpb.Empty, error) {
EmptyCallF: func(_ context.Context, _ *testpb.Empty) (*testpb.Empty, error) {
return &testpb.Empty{}, nil
},
UnaryCallF: func(ctx context.Context, in *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
UnaryCallF: func(_ context.Context, _ *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
return &testpb.SimpleResponse{}, nil
},
FullDuplexCallF: func(stream testgrpc.TestService_FullDuplexCallServer) error {
Expand Down Expand Up @@ -1125,7 +1125,7 @@ func (s) TestMetadataTruncationAccountsKey(t *testing.T) {
newLoggingExporter = ne
}(newLoggingExporter)

newLoggingExporter = func(ctx context.Context, config *config) (loggingExporter, error) {
newLoggingExporter = func(_ context.Context, _ *config) (loggingExporter, error) {
return fle, nil
}

Expand All @@ -1149,7 +1149,7 @@ func (s) TestMetadataTruncationAccountsKey(t *testing.T) {
defer cleanup()

ss := &stubserver.StubServer{
UnaryCallF: func(ctx context.Context, in *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
UnaryCallF: func(_ context.Context, _ *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
return &testpb.SimpleResponse{}, nil
},
}
Expand Down Expand Up @@ -1240,6 +1240,7 @@ func (s) TestMetadataTruncationAccountsKey(t *testing.T) {
// TestMethodInConfiguration tests different method names with an expectation on
// whether they should error or not.
func (s) TestMethodInConfiguration(t *testing.T) {

// To skip creating a stackdriver exporter.
fle := &fakeLoggingExporter{
t: t,
Expand All @@ -1249,7 +1250,7 @@ func (s) TestMethodInConfiguration(t *testing.T) {
newLoggingExporter = ne
}(newLoggingExporter)

newLoggingExporter = func(ctx context.Context, config *config) (loggingExporter, error) {
newLoggingExporter = func(_ context.Context, _ *config) (loggingExporter, error) {
return fle, nil
}

Expand Down
2 changes: 1 addition & 1 deletion interop/grpclb_fallback/client_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func doRPCAndGetPath(client testgrpc.TestServiceClient, timeout time.Duration) t
}

func dialTCPUserTimeout(ctx context.Context, addr string) (net.Conn, error) {
control := func(network, address string, c syscall.RawConn) error {
control := func(_, _ string, c syscall.RawConn) error {
var syscallErr error
controlErr := c.Control(func(fd uintptr) {
syscallErr = syscall.SetsockoptInt(int(fd), syscall.IPPROTO_TCP, unix.TCP_USER_TIMEOUT, 20000)
Expand Down
4 changes: 2 additions & 2 deletions xds/internal/balancer/clusterimpl/clusterimpl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func (b *clusterImplBalancer) ResolverError(err error) {
})
}

func (b *clusterImplBalancer) updateSubConnState(sc balancer.SubConn, s balancer.SubConnState, cb func(balancer.SubConnState)) {
func (b *clusterImplBalancer) updateSubConnState(_ balancer.SubConn, s balancer.SubConnState, cb func(balancer.SubConnState)) {
// Trigger re-resolution when a SubConn turns transient failure. This is
// necessary for the LogicalDNS in cluster_resolver policy to re-resolve.
//
Expand All @@ -297,7 +297,7 @@ func (b *clusterImplBalancer) UpdateSubConnState(sc balancer.SubConn, s balancer
}

func (b *clusterImplBalancer) Close() {
b.serializer.TrySchedule(func(ctx context.Context) {
b.serializer.TrySchedule(func(_ context.Context) {
b.child.Close()
b.childState = balancer.State{}

Expand Down
Loading