Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem: replace flate.Reader reference #7595

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Sep 8, 2024

This interface has nothing to do with compression and there are no other references to that package in the codebase. If we remove the reference we same compiler and linker some work - no need to parse, compile, link that package just to use one interface from it (assuming no other references from the codebase).

RELEASE NOTES:

  • mem: remove dependency on compress/flate package

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (3ffb98b) to head (614fd7f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7595      +/-   ##
==========================================
+ Coverage   81.87%   81.88%   +0.01%     
==========================================
  Files         361      361              
  Lines       27813    27813              
==========================================
+ Hits        22773    22776       +3     
- Misses       3843     3846       +3     
+ Partials     1197     1191       -6     
Files with missing lines Coverage Δ
mem/buffer_slice.go 96.20% <ø> (ø)

... and 27 files with indirect coverage changes

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PapaCharlie
Copy link
Contributor

Yep makes sense to me!

@dfawley dfawley added this to the 1.67 Release milestone Sep 9, 2024
@purnesh42H purnesh42H modified the milestones: 1.67 Release, 1.68 Release Sep 10, 2024
@arjan-bal arjan-bal modified the milestones: 1.68 Release, 1.67 Release Sep 10, 2024
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Sep 11, 2024
@dfawley dfawley added Type: Dependencies Updating/adding/removing dependencies and removed Type: Internal Cleanup Refactors, etc labels Sep 11, 2024
@dfawley dfawley merged commit 7fb7ac7 into grpc:master Sep 11, 2024
13 of 14 checks passed
@ash2k ash2k deleted the remove-flate-ref branch September 11, 2024 17:22
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Sep 11, 2024
dfawley pushed a commit that referenced this pull request Sep 11, 2024
arjan-bal pushed a commit to arjan-bal/grpc-go that referenced this pull request Sep 17, 2024
arjan-bal added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants