-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Bump Go version in Dockerfiles and test/kokoro/xds.sh #7629
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7629 +/- ##
==========================================
- Coverage 81.86% 81.76% -0.11%
==========================================
Files 361 361
Lines 27817 27817
==========================================
- Hits 22773 22745 -28
- Misses 3849 3867 +18
- Partials 1195 1205 +10 |
@@ -16,7 +16,7 @@ | |||
# following command from grpc-go directory: | |||
# docker build -t <TAG> -f interop/xds/client/Dockerfile . | |||
|
|||
FROM golang:1.21-alpine as build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go 1.23 is out now -- should we go straight to that version instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to go1.23
. Also changed remaining Dockerfiles in the repo and test/kokoro/xds.sh
to use go1.23
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Then we won't need to update again in 6 months.
@@ -16,7 +16,7 @@ | |||
# following command from grpc-go directory: | |||
# docker build -t <TAG> -f interop/xds/client/Dockerfile . | |||
|
|||
FROM golang:1.21-alpine as build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Then we won't need to update again in 6 months.
Since the minimum supported Go version was bumped in #7624, the Docker build for the psm interop client and server has been failing with the following error:
Verified that the docker build succeeds with the change in base image version to 1.22.
Verified that the download URL still works in
xds.sh
.gofilename=go1.23.0.linux-amd64.tar.gz curl --retry 3 -O -L "https://go.dev/dl/${gofilename}"
RELEASE NOTES: N/A