Supressed warning for using listening_addresses in Node and added TOD…

…O for cleaning it up.
grpc · Sep 21, 2020 · 125d96d · 125d96d
1 parent 1f0e0c2
commit 125d96d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/xds/src/main/java/io/grpc/xds/EnvoyProtoData.java b/xds/src/main/java/io/grpc/xds/EnvoyProtoData.java
@@ -226,6 +226,7 @@ static final class Builder {
       private Map<String, ?> metadata;
       @Nullable
       private Locality locality;
+      // TODO(sanjaypujare): eliminate usage of listening_addresses field.
       private final List<Address> listeningAddresses = new ArrayList<>();
       private String buildVersion = "";
       private String userAgentName = "";

diff --git a/xds/src/main/java/io/grpc/xds/XdsClientImpl.java b/xds/src/main/java/io/grpc/xds/XdsClientImpl.java
@@ -462,6 +462,7 @@ private void updateNodeMetadataForListenerRequest(int port) {
       newMetadata.putAll(node.getMetadata());
     }
     newMetadata.put("TRAFFICDIRECTOR_PROXYLESS", "1");
+    // TODO(sanjaypujare): eliminate usage of listening_addresses.
     EnvoyProtoData.Address listeningAddress =
         new EnvoyProtoData.Address("0.0.0.0", port);
     node =

diff --git a/xds/src/test/java/io/grpc/xds/EnvoyProtoDataTest.java b/xds/src/test/java/io/grpc/xds/EnvoyProtoDataTest.java
@@ -96,6 +96,7 @@ public void locality_equal() {
         .testEquals();
   }
 
+  @SuppressWarnings("deprecation")
   @Test
   public void convertNode() {
     Node node = Node.newBuilder()