Skip to content

Commit

Permalink
Drop @grpc_java from labels
Browse files Browse the repository at this point in the history
These don't contribute if grpc-java is imported with name = grpc_java,
and break the build if grpc-java is imported with another name.
  • Loading branch information
cgrushko authored and ejona86 committed Feb 21, 2018
1 parent 38c84ed commit 137c74d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions java_grpc_library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ _gensource = rule(
cfg = "host",
),
"_java_plugin": attr.label(
default = Label("@grpc_java//compiler:grpc_java_plugin"),
default = Label("//compiler:grpc_java_plugin"),
executable = True,
cfg = "host",
),
Expand Down Expand Up @@ -107,9 +107,9 @@ def java_grpc_library(name, srcs, deps, flavor=None,
)

added_deps = [
"@grpc_java//core",
"@grpc_java//stub",
"@grpc_java//protobuf",
"//core",
"//stub",
"//protobuf",
"@com_google_guava_guava//jar",
]
if flavor == "normal":
Expand Down

0 comments on commit 137c74d

Please sign in to comment.