all: add toString() to Server to improve debug info

grpc · Apr 13, 2018 · a6811d5 · a6811d5
1 parent 0eafb8e
commit a6811d5
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/alts/src/main/java/io/grpc/alts/AltsServerBuilder.java b/alts/src/main/java/io/grpc/alts/AltsServerBuilder.java
@@ -16,6 +16,7 @@
 
 package io.grpc.alts;
 
+import com.google.common.base.MoreObjects;
 import io.grpc.BindableService;
 import io.grpc.CompressorRegistry;
 import io.grpc.DecompressorRegistry;
@@ -248,5 +249,10 @@ public boolean awaitTermination(long timeout, TimeUnit unit) throws InterruptedE
     public void awaitTermination() throws InterruptedException {
       delegate.awaitTermination();
     }
+
+    @Override
+    public String toString() {
+      return MoreObjects.toStringHelper(this).add("delegate", delegate).toString();
+    }
   }
 }
diff --git a/core/src/main/java/io/grpc/inprocess/InProcessServer.java b/core/src/main/java/io/grpc/inprocess/InProcessServer.java
@@ -18,6 +18,7 @@
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import com.google.common.base.MoreObjects;
 import io.grpc.ServerStreamTracer;
 import io.grpc.internal.Channelz.SocketStats;
 import io.grpc.internal.Instrumented;
@@ -95,6 +96,11 @@ public void shutdown() {
     }
   }
 
+  @Override
+  public String toString() {
+    return MoreObjects.toStringHelper(this).add("name", name).toString();
+  }
+
   synchronized ServerTransportListener register(InProcessTransport transport) {
     if (shutdown) {
       return null;

diff --git a/core/src/main/java/io/grpc/internal/ServerImpl.java b/core/src/main/java/io/grpc/internal/ServerImpl.java
@@ -25,6 +25,7 @@
 import static java.util.concurrent.TimeUnit.NANOSECONDS;
 
 import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.MoreObjects;
 import com.google.common.base.Preconditions;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.SettableFuture;
@@ -580,6 +581,14 @@ public ListenableFuture<ServerStats> getStats() {
     return ret;
   }
 
+  @Override
+  public String toString() {
+    return MoreObjects.toStringHelper(this)
+        .add("logId", logId)
+        .add("transportServer", transportServer)
+        .toString();
+  }
+
   private static final class NoopListener implements ServerStreamListener {
     @Override
     public void messagesAvailable(MessageProducer producer) {

diff --git a/netty/src/main/java/io/grpc/netty/NettyServer.java b/netty/src/main/java/io/grpc/netty/NettyServer.java
@@ -21,6 +21,7 @@
 import static io.netty.channel.ChannelOption.SO_BACKLOG;
 import static io.netty.channel.ChannelOption.SO_KEEPALIVE;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -304,6 +305,14 @@ public LogId getLogId() {
     return logId;
   }
 
+  @Override
+  public String toString() {
+    return MoreObjects.toStringHelper(this)
+        .add("logId", logId)
+        .add("address", address)
+        .toString();
+  }
+
   class EventLoopReferenceCounter extends AbstractReferenceCounted {
     @Override
     protected void deallocate() {