Remove TODOs about checking stats collection state.

gRPC shouldn't use the state to determine whether to initialize the CensusStatsModule, because the state can be changed at runtime.
grpc · Nov 2, 2017 · c724318 · c724318
1 parent adff468
commit c724318
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
@@ -365,9 +365,6 @@ final List<ClientInterceptor> getEffectiveInterceptors() {
               : Tags.getTagPropagationComponent().getBinarySerializer();
       StatsRecorder statsRecorder =
           this.statsRecorder != null ? this.statsRecorder : Stats.getStatsRecorder();
-      // // TODO: How do we check whether stats is enabled, now that the StatsRecorder is always
-      // // non-null? Uncommenting this line causes test failures.
-      // if (Stats.getState() == StatsCollectionState.ENABLED) {
       CensusStatsModule censusStats =
           new CensusStatsModule(
               tagger,
@@ -379,7 +376,6 @@ final List<ClientInterceptor> getEffectiveInterceptors() {
       // First interceptor runs last (see ClientInterceptors.intercept()), so that no
       // other interceptor can override the tracer factory we set in CallOptions.
       effectiveInterceptors.add(0, censusStats.getClientInterceptor());
-                               // }
     }
     if (tracingEnabled) {
       CensusTracingModule censusTracing =

diff --git a/core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java
@@ -249,9 +249,6 @@ final List<ServerStreamTracer.Factory> getTracerFactories() {
               : Tags.getTagPropagationComponent().getBinarySerializer();
       StatsRecorder statsRecorder =
           this.statsRecorder != null ? this.statsRecorder : Stats.getStatsRecorder();
-      // // TODO: How do we check whether stats is enabled, now that the StatsRecorder is always
-      // // non-null? Uncommenting this line causes test failures.
-      // if (Stats.getState() == StatsCollectionState.ENABLED) {
       CensusStatsModule censusStats =
           new CensusStatsModule(
               tagger,
@@ -261,7 +258,6 @@ final List<ServerStreamTracer.Factory> getTracerFactories() {
               true,
               recordStats);
       tracerFactories.add(censusStats.getServerTracerFactory());
-      // }
     }
     if (tracingEnabled) {
       CensusTracingModule censusTracing =