-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netty upgrade to 4.1.110 in grpc-java #11273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MODULE.bazel
also needs updating. That is why the Bazel test is failing.
Done. |
justFYI: |
I reported #11284 about 4.1.111.Final. It would be useful to run CI with it to see what breaks. |
It can flake. Follow the link to Test Fusion and click the "rebuild" button. |
This needs to be backported to the 1.66 branch. Easiest way is to use https://gist.github.com/sergiitk/af606cbab72b00d8db8a53d21e766ee9 ( |
This reverts commit f9b072c. Changes from the release process got mixed in with the commit.
Reverting in #11440 |
This reverts commit f9b072c. Changes from the release process got mixed in with the commit.
Once I noticed there were unintended commits that caused test failure I panic reverted them but I didn't notice there were more commits to revert (there were 4 but I only noticed 2) so my revert left things in a half baked state. I had thought once certain changes are committed to a branch https://screenshot.googleplex.com/86pkpKBjbbagzvR they belong to that branch. But what is happening is that they get carried over when I switch branch and get committed again with a different hash. I don't really understand how this works. I know commits carry over if I do checkout -b but I only checked out an existing branch in this case. @ejona86 |
Commits stay on branches, but certain operations can copy commits between branches, like rebase and merge. I could probably look at your bash history to figure out how it happened. It does seem like it is happening very frequently for you. |
Netty upgrade to 4.1.110 in grpc-java
Issue #11150