Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow tests that took 40 seconds to get through tearDown. #11530

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

larry-safran
Copy link
Contributor

@larry-safran larry-safran commented Sep 16, 2024

Move awaitTermination to after the server shutdown.

Fixes #11527

@ejona86
Copy link
Member

ejona86 commented Sep 16, 2024

Fixes #11527

@larry-safran larry-safran merged commit bdc0530 into grpc:master Sep 17, 2024
15 checks passed
@larry-safran larry-safran deleted the s2a_slow_test branch September 17, 2024 18:12
@rmehta19
Copy link
Contributor

Thank you for the fix Larry!

kannanjgithub pushed a commit to kannanjgithub/grpc-java that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s2a tests are way too slow
3 participants