Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2a: Move s2a implementation to internal package. #11541

Merged
merged 5 commits into from
Oct 1, 2024
Merged

s2a: Move s2a implementation to internal package. #11541

merged 5 commits into from
Oct 1, 2024

Conversation

rmehta19
Copy link
Contributor

No description provided.

@rmehta19 rmehta19 marked this pull request as draft September 20, 2024 15:23
@rmehta19 rmehta19 mentioned this pull request Sep 20, 2024
Merged
@rmehta19 rmehta19 marked this pull request as ready for review September 30, 2024 19:35
@rmehta19
Copy link
Contributor Author

Also updated upstream protos in grpc-proto: grpc/grpc-proto#161

@larry-safran larry-safran added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 30, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 30, 2024
@ejona86
Copy link
Member

ejona86 commented Sep 30, 2024

There's a conflict in S2AStub

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 30, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 30, 2024
@ejona86 ejona86 merged commit 927d215 into grpc:master Oct 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry-safran larry-safran larry-safran approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmehta19 @ejona86 @larry-safran @grpc-kokoro