Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2a: Enable publishing. #11581

Merged
merged 1 commit into from
Oct 10, 2024
Merged

s2a: Enable publishing. #11581

merged 1 commit into from
Oct 10, 2024

Conversation

rmehta19
Copy link
Contributor

@rmehta19 rmehta19 commented Oct 1, 2024

There are a few comments which we will get to in followup CL's:
#11540
#11534
#11539
#11113 (comment)

I think all major comments / refactoring after #11113 have been addressed. Are we ok to enable publishing of s2a?

@ejona86
Copy link
Member

ejona86 commented Oct 1, 2024

We still have multiple lifetime/resource problems that need to be resolved.

@rmehta19
Copy link
Contributor Author

rmehta19 commented Oct 4, 2024

@ejona86 I believe this discussion about closing the stub: #11113 (comment) and this one about tls version: #11588 (comment) are the only open item before publishing, correct?

@ejona86
Copy link
Member

ejona86 commented Oct 4, 2024

Yeah, I think those are the only blockers here. I was most concerned with lifecycle issues, as they can be harder to debug and harder to fix. Lack of protocol forward compatibility (like we saw with TLS) is serious, but I wasn't really reviewing for it as that's something that is important for y'all and doesn't impact me much. And I have very low understanding of the protocol.

#11587 is causing trouble, so that should be fixed (but should be trivial).

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 4, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 4, 2024
@rmehta19
Copy link
Contributor Author

rmehta19 commented Oct 5, 2024

@ejona86
Copy link
Member

ejona86 commented Oct 10, 2024

This can go in once #11600 (or similar) goes in.

@larry-safran larry-safran merged commit a01a9e2 into grpc:master Oct 10, 2024
15 checks passed
kannanjgithub pushed a commit to kannanjgithub/grpc-java that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants