Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2a: Address comments on S2A channel + stub #11584

Merged
merged 2 commits into from
Oct 2, 2024
Merged

s2a: Address comments on S2A channel + stub #11584

merged 2 commits into from
Oct 2, 2024

Conversation

rmehta19
Copy link
Contributor

@rmehta19 rmehta19 commented Oct 1, 2024 •
edited
Loading

Address discussions:

@rmehta19 rmehta19 marked this pull request as draft October 2, 2024 00:06
@rmehta19 rmehta19 marked this pull request as ready for review October 2, 2024 05:27
@larry-safran larry-safran added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 2, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 2, 2024
@larry-safran larry-safran merged commit 959060a into grpc:master Oct 2, 2024
15 checks passed
kannanjgithub pushed a commit to kannanjgithub/grpc-java that referenced this pull request Oct 23, 2024
@rmehta19 @kannanjgithub
s2a: Address comments on S2A channel + stub (grpc#11584)
f337b90 
* delete HandshakerServiceChannel.

* remove usage of S2AGrpcChannelPool + avoid creating Channel ref per conn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry-safran larry-safran larry-safran approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmehta19 @ejona86 @larry-safran @grpc-kokoro