-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: use new OpenCensus stats/tagging API. #3647
Merged
Merged
Commits on Nov 3, 2017
-
core: use new OpenCensus stats/tagging API.
This commit updates gRPC core to use io.opencensus:opencensus-api and io.opencensus:opencensus-contrib-grpc-metrics instead of com.google.instrumentation:instrumentation-api for stats and tagging. The gRPC Monitoring Service continues to use instrumentation-api. The main changes affecting gRPC: - The StatsContextFactory is replaced by three objects, StatsRecorder, Tagger, and TagContextBinarySerializer. - The StatsRecorder, Tagger, and TagContextBinarySerializer are never null, but the objects are no-ops when the OpenCensus implementation is not available. This commit includes changes written by @songy23 and @sebright.
Configuration menu - View commit details
-
Copy full SHA for f03ae78 - Browse repository at this point
Copy the full SHA f03ae78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e01775 - Browse repository at this point
Copy the full SHA 4e01775View commit details -
Remove TODOs about checking stats collection state.
gRPC shouldn't use the state to determine whether to initialize the CensusStatsModule, because the state can be changed at runtime.
Configuration menu - View commit details
-
Copy full SHA for 611878c - Browse repository at this point
Copy the full SHA 611878cView commit details -
Refactor the code for overriding the Census implementation in tests.
This commit adds a method to set the CensusStatsModule on AbstractServerImplBuilder and AbstractManagedChannelImplBuilder. It is simpler to set the whole CensusStatsModule than pass in all necessary OpenCensus implementation objects.
Configuration menu - View commit details
-
Copy full SHA for d921df5 - Browse repository at this point
Copy the full SHA d921df5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca7ad9a - Browse repository at this point
Copy the full SHA ca7ad9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fe19a2 - Browse repository at this point
Copy the full SHA 7fe19a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45419c2 - Browse repository at this point
Copy the full SHA 45419c2View commit details
Commits on Nov 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 403c6e3 - Browse repository at this point
Copy the full SHA 403c6e3View commit details
Commits on Nov 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4f0d7c5 - Browse repository at this point
Copy the full SHA 4f0d7c5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.