-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping proto-google-common-protos to 1.0.0 #3765
Conversation
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Reverify me, linuxfoundation! |
@garrettjonesgoogle, would this be good to backport to the 1.8 release next week? |
It's really just about guarantee of surface stability - there might be some extra protos in there but I'm not sure. I think it really depends if you want to "hand over" this surface stability to users of 1.8; there is very little risk to backporting it. |
Okay. We didn't stabilize the API that uses it in 1.8, and we'd still need to figure out Java 6 vs Java 7 bytecode before we could. So I won't bother backporting, since it's not really a bug and there's no need. |
We recently released proto-google-common-protos to 1.0.0.