core: support user-agent in InProcess #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyane
force-pushed
the
add-user-agent-to-inprocess
branch
from
01828c2
to
4289fba
Compare
ejona86
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
| @@ -143,6 +146,9 @@ public void start(ClientStreamListener listener) { | |||
| } | |||
| }; | |||
| } | |||
| headers.put( | |||
| GrpcUtil.USER_AGENT_KEY, | |||
| GrpcUtil.getGrpcUserAgent("inprocess", userAgent)); | |||
There was a problem hiding this comment.
nit: the agent should be a final var for this instance.
zpencer
approved these changes
Dec 11, 2017
|
I created #3860 for the optimization. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, InProcess(io.grpc.inprocess) does not support the use of a user-agent, but it may be useful for testing of
LoggingInterceptor(It is just an example, it records the status, responses, user-agent, etc to log files).