Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY.md: Add reference to grpc-netty-shaded #4185

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Mar 7, 2018

Many people going to the troubleshooting section would be fixed by
swapping to grpc-netty-shaded, so we should call that out.

@saturnism, would you mind reviewing?

@ejona86 ejona86 added the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Mar 19, 2018
@saturnism
Copy link
Contributor

LGTM. I feel most of the content can be added w/ the changes in #4236

@ejona86
Copy link
Member Author

ejona86 commented Mar 23, 2018

@saturnism, could you do the GitHub review and approve? (just saying LGTM doesn't let me merge; we require a github review)

Many people going to the troubleshooting section would be fixed by
swapping to grpc-netty-shaded, so we should call that out.
@ejona86 ejona86 removed the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Mar 23, 2018
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 41e98ef into grpc:master Apr 3, 2018
@ejona86 ejona86 deleted the security-shaded branch April 3, 2018 15:45
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants