Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: allow capitalized java keywords as rpc names #4309

Merged
merged 4 commits into from
Apr 5, 2018
Merged

compiler: allow capitalized java keywords as rpc names #4309

merged 4 commits into from
Apr 5, 2018

Commits on Apr 5, 2018

  1. compiler: allow capitalized java keywords as rpc names 

    previously `Import` fails because it gets turned into a method named
`import`. This PR makes the method be named `import_`, everything else
stays the same, such as the name in the method descriptor.

Note: `iMport` or `iMPORT` or any variation of capitalizations that is
not `Import` always worked. `Import` gets translated into `import`
because of our attempts to camel case the names.
    @zpencer
    zpencer committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    0eef2c6 View commit details
    Browse the repository at this point in the history

  2. use better URL reference for keywords

    @zpencer
    zpencer committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    9290631 View commit details
    Browse the repository at this point in the history

  3. remove unused msgs

    @zpencer
    zpencer committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    a98c221 View commit details
    Browse the repository at this point in the history

  4. invert if cases

    @zpencer
    zpencer committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    fd115b6 View commit details
    Browse the repository at this point in the history