Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: forward toString for forwarding classes #4337

Merged
merged 1 commit into from
Apr 19, 2018
Merged

core: forward toString for forwarding classes #4337

merged 1 commit into from
Apr 19, 2018

Conversation

dapengzhang0
Copy link
Member

Forward toString() method for forwarding classes to improve debug information.

For example, ForwardingManagedChannel.toString() will return something like:

ForwardingManagedChannel{delegate=ManagedChannelImpl{logId=tag-13247, target=localhost:8080}}

@dapengzhang0
Copy link
Member Author

@zpencer thanks!

@dapengzhang0 dapengzhang0 merged commit f6a032d into grpc:master Apr 19, 2018
@dapengzhang0 dapengzhang0 deleted the forwardtostring branch May 2, 2018 17:15
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zpencer zpencer zpencer approved these changes

Assignees

@zpencer zpencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapengzhang0 @zpencer