Skip to content

Commit

Permalink
try to remove stub-lite for #234
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesward committed Feb 26, 2021
1 parent 501df14 commit 825af21
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 67 deletions.
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

[![grpc-kotlin-stub][label:stub]][maven:stub]
[![protoc-gen-grpc-kotlin][label:plugin]][maven:plugin]
[![grpc-kotlin-stub-lite][label:stub-lite]][maven:stub-lite]

A Kotlin/JVM implementation of [gRPC](https://grpc.io): A high performance, open
source, general RPC framework that puts mobile and HTTP/2 first.
Expand All @@ -23,10 +22,6 @@ This repo includes the sources for the following:
- [grpc-kotlin-stub](stub): A Kotlin implementation of gRPC, providing runtime
support for client-stubs and server-side code.

- [grpc-kotlin-stub-lite](stub-lite): An implementation of `grpc-kotlin-stub`,
but with a dependency on `grpc-protobuf-lite` instead of `grpc-protobuf` for
Android projects.

For more information, see the following [Kotlin/JVM pages from grpc.io][]:

- [Quick start][]
Expand All @@ -40,6 +35,13 @@ How-to pages from this repo:

Note that [official releases][] are [published to Maven Central][].

## Upgrading

### 1.0.0 -> 1.1.0

TODO


[API Reference]: https://grpc.io/docs/languages/kotlin/api/
[Basics tutorial]: https://grpc.io/docs/languages/kotlin/basics/
[Bazel Build Status]: https://github.com/grpc/grpc-kotlin/workflows/Bazel%20Build/badge.svg
Expand All @@ -48,10 +50,8 @@ Note that [official releases][] are [published to Maven Central][].
[Kotlin/JVM pages from grpc.io]: https://grpc.io/docs/languages/kotlin/
[label:plugin]: https://img.shields.io/maven-central/v/io.grpc/protoc-gen-grpc-kotlin.svg?label=protoc-gen-grpc-kotlin
[label:stub]: https://img.shields.io/maven-central/v/io.grpc/grpc-kotlin-stub.svg?label=grpc-kotlin-stub
[label:stub-lite]: https://img.shields.io/maven-central/v/io.grpc/grpc-kotlin-stub-lite.svg?label=grpc-kotlin-stub-lite
[maven:plugin]: https://search.maven.org/search?q=g:%22io.grpc%22%20AND%20a:%22protoc-gen-grpc-kotlin%22
[maven:stub]: https://search.maven.org/search?q=g:%22io.grpc%22%20AND%20a:%22grpc-kotlin-stub%22
[maven:stub-lite]: https://search.maven.org/search?q=g:%22io.grpc%22%20AND%20a:%22grpc-kotlin-stub-lite%22
[official releases]: https://github.com/grpc/grpc-kotlin/releases
[protoc]: https://github.com/protocolbuffers/protobuf#protocol-compiler-installation
[protocolbuffers/protobuf#3742]: https://github.com/protocolbuffers/protobuf/issues/3742
Expand Down
8 changes: 2 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ subprojects {
apply plugin: 'java'
apply plugin: 'org.jetbrains.kotlin.jvm'
group = "io.grpc"
version = "1.0.0" // CURRENT_GRPC_KOTLIN_VERSION
version = "1.1.0-SNAPSHOT" // CURRENT_GRPC_KOTLIN_VERSION
repositories {
mavenCentral()
}
Expand Down Expand Up @@ -53,11 +53,7 @@ subprojects {
}
}

if (
project.name == "grpc-kotlin-stub"
|| project.name == "grpc-kotlin-compiler"
|| project.name == "grpc-kotlin-stub-lite"
) {
if (project.name == "grpc-kotlin-stub" || project.name == "grpc-kotlin-compiler") {
apply plugin: 'maven-publish'

plugins.withId("maven-publish") {
Expand Down
9 changes: 6 additions & 3 deletions examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,12 @@ The example sources are organized into the following top-level folders:
mkdir android-sdk
cd android-sdk
unzip PATH_TO_SDK_ZIP/sdk-tools-linux-VERSION.zip
tools/bin/sdkmanager --update
tools/bin/sdkmanager "platforms;android-30" "build-tools;30.0.2" "extras;google;m2repository" "extras;android;m2repository"
tools/bin/sdkmanager --licenses
mv cmdline-tools latest
mkdir cmdline-tools
mv latest cmdline-tools
cmdline-tools/latest/bin/sdkmanager --update
cmdline-tools/latest/bin/sdkmanager "platforms;android-30" "build-tools;30.0.2" "extras;google;m2repository" "extras;android;m2repository"
cmdline-tools/latest/bin/sdkmanager --licenses
```

1. Set an env var pointing to the `android-sdk`
Expand Down
2 changes: 1 addition & 1 deletion examples/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {

// todo: move to subprojects, but how?
ext["grpcVersion"] = "1.32.1"
ext["grpcKotlinVersion"] = "1.0.0" // CURRENT_GRPC_KOTLIN_VERSION
ext["grpcKotlinVersion"] = "1.1.0-SNAPSHOT" // CURRENT_GRPC_KOTLIN_VERSION
ext["protobufVersion"] = "3.13.0"

allprojects {
Expand Down
4 changes: 3 additions & 1 deletion examples/stub-android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.8")
implementation("javax.annotation:javax.annotation-api:1.3.2")

api("io.grpc:grpc-protobuf-lite:${rootProject.ext["grpcVersion"]}")
api("io.grpc:grpc-kotlin-stub:${rootProject.ext["grpcKotlinVersion"]}")
api("com.google.guava:guava:28.2-android")
api("com.google.protobuf:protobuf-javalite:${rootProject.ext["protobufVersion"]}")
api("io.grpc:grpc-kotlin-stub-lite:${rootProject.ext["grpcKotlinVersion"]}")
}

android {
Expand Down
4 changes: 3 additions & 1 deletion examples/stub-lite/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.8")
implementation("javax.annotation:javax.annotation-api:1.3.2")

api("io.grpc:grpc-protobuf-lite:${rootProject.ext["grpcVersion"]}")
api("io.grpc:grpc-kotlin-stub:${rootProject.ext["grpcKotlinVersion"]}")
api("com.google.guava:guava:28.2-jre")
api("com.google.protobuf:protobuf-javalite:${rootProject.ext["protobufVersion"]}")
api("io.grpc:grpc-kotlin-stub-lite:${rootProject.ext["grpcKotlinVersion"]}")
}

java {
Expand Down
1 change: 1 addition & 0 deletions examples/stub/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.8")
implementation("javax.annotation:javax.annotation-api:1.3.2")

api("io.grpc:grpc-protobuf:${rootProject.ext["grpcVersion"]}")
api("com.google.protobuf:protobuf-java-util:${rootProject.ext["protobufVersion"]}")
api("io.grpc:grpc-kotlin-stub:${rootProject.ext["grpcKotlinVersion"]}")
}
Expand Down
2 changes: 0 additions & 2 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ rootProject.name = "grpc-kotlin"
include 'interop_testing'
include ":grpc-kotlin-stub"
project(':grpc-kotlin-stub').projectDir = "$rootDir/stub" as File
include ":grpc-kotlin-stub-lite"
project(':grpc-kotlin-stub-lite').projectDir = "$rootDir/stub-lite" as File

if (settings.hasProperty('skipCodegen') && skipCodegen.toBoolean()) {
println '*** Skipping the build of codegen and compilation of proto files because skipCodegen=true'
Expand Down
45 changes: 0 additions & 45 deletions stub-lite/build.gradle

This file was deleted.

1 change: 0 additions & 1 deletion stub/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ dependencies {
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:${rootProject.ext.coroutinesVersion}"

// Grpc and Protobuf
api "io.grpc:grpc-protobuf:${rootProject.ext.grpcVersion}"
api "io.grpc:grpc-stub:${rootProject.ext.grpcVersion}"

// Java
Expand Down

0 comments on commit 825af21

Please sign in to comment.