grpc-js: Fix call ref timer handling

grpc · Dec 1, 2023 · 4dfd8c4 · 4dfd8c4
1 parent 202a735
commit 4dfd8c4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/grpc-js/package.json b/packages/grpc-js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@grpc/grpc-js",
-  "version": "1.9.12",
+  "version": "1.9.13",
   "description": "gRPC Library for Node - pure JS implementation",
   "homepage": "https://grpc.io/",
   "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",

diff --git a/packages/grpc-js/src/internal-channel.ts b/packages/grpc-js/src/internal-channel.ts
@@ -296,7 +296,9 @@ export class InternalChannel {
         this.currentPicker = picker;
         const queueCopy = this.pickQueue.slice();
         this.pickQueue = [];
-        this.callRefTimerUnref();
+        if (queueCopy.length > 0) {
+          this.callRefTimerUnref();
+        }
         for (const call of queueCopy) {
           call.doPick();
         }
@@ -349,11 +351,12 @@ export class InternalChannel {
         process.nextTick(() => {
           const localQueue = this.configSelectionQueue;
           this.configSelectionQueue = [];
-          this.callRefTimerUnref();
+          if (localQueue.length > 0) {
+            this.callRefTimerUnref();
+          }
           for (const call of localQueue) {
             call.getConfig();
           }
-          this.configSelectionQueue = [];
         });
       },
       status => {
@@ -380,7 +383,9 @@ export class InternalChannel {
         }
         const localQueue = this.configSelectionQueue;
         this.configSelectionQueue = [];
-        this.callRefTimerUnref();
+        if (localQueue.length > 0) {
+          this.callRefTimerUnref();
+        }
         for (const call of localQueue) {
           call.reportResolverError(status);
         }