Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, pre-compiled binary of
grpc-tools
is missing for M1 mac (arm64).#1405
It is possible to run M1 mac by setting
npm_config_target_arch=x64
, but it is a little bit messy.It must be straightforward to wait for M1 build machines in GitHub action,
#1405 (comment)
but we can build universal binaries by setting
-DCMAKE_OSX_ARCHITECTURES="arm64;x86_64"
tocmake
, and can extract binaries for x86_64/arm64 usinglipo
.Or, it would be good to provide universal binaries without separating binaries.
In my Macbook (intel), I can successfully build both x86_64 and arm64 binaries.