Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Fix pick_first reconnecting without active calls #2784

Conversation

murgatroid99
Copy link
Member

This is another attempt at fixing #2718. The previous attempt, #2680, failed because of #2690. I believe I have fixed that this time. With the original change, I reproduced a failure like the one reported: if the server dropped each connection after 1 second, and the client made requests as quickly as possible, after only a couple of minutes the client would entirely stop attempting to reconnect. With the change to handle ready subchannels in connectToAddressList, I ran the same test for half an hour without any problem.

@murgatroid99 murgatroid99 merged commit f8338c5 into grpc:@grpc/[email protected] Jul 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants