You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a couple of method signatures in the generated TypeScript client that should mark the metadata parameter as optional, to reduce explicitly passing unnecessary null values:
Making the metadata parameter optional in the method returning a Promise would bring the TypeScript client closer in line with the PromiseClient interface available when generating with import_style=commonjs+dts.
The text was updated successfully, but these errors were encountered:
This is an inverse issue to #408
There are a couple of method signatures in the generated TypeScript client that should mark the
metadata
parameter as optional, to reduce explicitly passing unnecessarynull
values:grpc-web/javascript/net/grpc/web/generator/grpc_generator.cc
Lines 652 to 655 in 0ec55aa
grpc-web/javascript/net/grpc/web/generator/grpc_generator.cc
Lines 670 to 674 in 0ec55aa
Making the
metadata
parameter optional in the method returning aPromise
would bring the TypeScript client closer in line with thePromiseClient
interface available when generating withimport_style=commonjs+dts
.The text was updated successfully, but these errors were encountered: