Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ES6 .d.ts imports with comment about corresponding proto import path #1330

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

gonzojive
Copy link
Contributor

@gonzojive gonzojive commented Apr 15, 2023

#1313 updated the code generator to print a // proto import: "foo/bar.proto" suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.

…t path.

grpc#1313 updated the code generator to print a
`proto import: "foo/bar.proto"` suffix for each import statement for the
generated gRPC-web client code. This commit updates ensures the .d.ts file
output by grpc-web contains the same type of comments.
Copy link
Collaborator

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the change!

Sorry for the delay too — not sure why this slipped through my list!

@gonzojive
Copy link
Contributor Author

Thanks. I just merged in the latest changes. I think @sampajano will need to trigger the tests and complete the merge.

@sampajano
Copy link
Collaborator

Thanks. I just merged in the latest changes. I think @sampajano will need to trigger the tests and complete the merge.

@gonzojive Yes will do! Thanks again for the change!

@sampajano sampajano merged commit 3cd7e0d into grpc:master Oct 5, 2023
gonzojive added a commit to gonzojive/rules_ts_proto that referenced this pull request Oct 7, 2023
grpc/grpc-web#1330 was merged, so there's no longer a
need to depend on a fork.
gonzojive added a commit to gonzojive/rules_ts_proto that referenced this pull request Oct 7, 2023
1. Update repository dependency to point to grpc/grpc-web. grpc/grpc-web#1330 was merged, so there's no longer a need to depend on a fork.
2. Add a test of the grpc-web functionality and require the grpc-web node module.
3. Ensure all rewritten imports include the ".mjs" suffix. It was previously omitted for some imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants