Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bazel WORKSPACE and BUILD file for protoc-gen-grpc-web #186

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented May 14, 2018

Bazel could help with the build enhancement issue #171 and building on windows #182

@stanley-cheung
Copy link
Collaborator

Thanks for your contribution! This may introduce a bit of trouble / conflict when we have to keep the BUILD file in sync with our internal code base. I will have to get back to this a bit later to figure out a way to easily keep this in sync.

@stanley-cheung
Copy link
Collaborator

Can you please rebase this PR? I plan to merge this ahead of #209 so your contribution can be preserved. Thanks!

@zaucy
Copy link
Contributor Author

zaucy commented Jul 27, 2018

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants