-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multiple proxies interoperability #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So pleased to finally see this interoperability done! Well done! This affects #91.
RUN go get -v -u github.com/golang/dep/cmd/dep | ||
RUN go get -v github.com/improbable-eng/grpc-web/go/grpcwebproxy ; exit 0 | ||
RUN cd src/github.com/improbable-eng/grpc-web && dep ensure | ||
RUN go get -v -u github.com/improbable-eng/grpc-web/go/grpcwebproxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should download a released version rather than just using go get.
https://github.com/improbable-eng/grpc-web/archive/0.6.2.tar.gz
Then download dep and run dep ensure as done here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry wasn't very familiar with go get
. Tried a bit just now and couldn't get it to work. Can you show me an example on how that's done?
I tried to download the tarball. Untar it. Which directory should I be running dep ensure
from? Do I need another go get
command after that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A complete installation would be:
# Install stable dep
curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
# Install stable proxy
wget https://github.com/improbable-eng/grpc-web/archive/0.6.2.tar.gz
tar xfv 0.6.2.tar.gz /go/src/github.com/improbable-eng/
cd /go/src/github.com/improbable-eng/grpc-web
dep ensure --vendor-only
# Build and install into /go/bin/grpcwebproxy
go install ./go/grpcwebproxy
Something like this. I haven't tried it, just writing from memory, but shouldn't be far off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I made the change and that seems to do it.
Content-Type: application/grpc-web-text
mode=grpcwebtext
in the code generatorContent-Type: application/grpc-web+proto
mode=grpcweb
in the code generator