update typescript generation to work in strict mode #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR fixes the issues brought up in #279.
The problem is that in typescripts strict mode, the type
{}
only matches empty objects exconst someVar = {}
, and not anything else.The following changes are made:
tsconfig.json
to usestrict
MethodInfo
/AbstractClientBase
/ClientReadableStream
to be generic overRequest
andResponse
typesClientReadableStream.on
to have correctcallback
type depending ontype
argumentnull
ascredentials
andoptions
I could not figure out where
credentials
andoptions
are used so I could not figure out the correct types. If you could point me in the right direction that would be great! :)