Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a max grpc timeout to the echo example. #352

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Add a max grpc timeout to the echo example. #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70afdae
Add a max grpc timeout to the echo example.
Nov 6, 2018
83f2c91
Fix code typo in echo tutorial
Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion net/grpc/gateway/examples/echo/envoy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ static_resources:
domains: ["*"]
routes:
- match: { prefix: "/" }
route: { cluster: echo_service }
route:
cluster: echo_service
max_grpc_timeout: 0s
cors:
allow_origin:
- "*"
Expand Down
6 changes: 4 additions & 2 deletions net/grpc/gateway/examples/echo/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ this:
domains: ["*"]
routes:
- match: { prefix: "/" }
route: { cluster: echo_service }
route:
cluster: echo_service
max_grpc_timeout: 0s
http_filters:
- name: envoy.grpc_web
- name: envoy.router
Expand Down Expand Up @@ -133,7 +135,7 @@ Our command generates the client stub, by default, to the file
Now you are ready to write some JS client code. Put this in a `client.js` file.

```js
const {EchoRequest, EchoResponse} = require('./echo_pb.js'));
const {EchoRequest, EchoResponse} = require('./echo_pb.js');
const {EchoServiceClient} = require('./echo_grpc_web_pb.js');

var echoService = new EchoServiceClient('http://localhost:8080');
Expand Down