Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use camelCase in AsObject definition #430

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Use camelCase in AsObject definition #430

merged 3 commits into from
Jan 8, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

Fixes #428

I think this fixes #428, but I'm not sure @maeb may not have wanted something else.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley-cheung stanley-cheung merged commit f181d1e into grpc:master Jan 8, 2019
@johanbrandhorst johanbrandhorst deleted the patch-2 branch January 8, 2019 09:17
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
* Reinstate integration tests

* Downgrade Karma

* Upgrade Karma to 4.0.0

* Upgrade Karma to 4.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field names of generated Typescript (typings) objects are UpperCamelCase
3 participants