-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Messages in typings extending jspb.Message #444
Merged
stanley-cheung
merged 2 commits into
grpc:master
from
shaxbee:typings-extend-jspb-message
Jan 30, 2019
Merged
feature: Messages in typings extending jspb.Message #444
stanley-cheung
merged 2 commits into
grpc:master
from
shaxbee:typings-extend-jspb-message
Jan 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
great! |
@stanley-cheung Added |
shaxbee
force-pushed
the
typings-extend-jspb-message
branch
from
January 29, 2019 09:32
400fcd0
to
601c8ec
Compare
stanley-cheung
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
rogchap
reviewed
Feb 1, 2019
loyalpartner
pushed a commit
to loyalpartner/grpc-web
that referenced
this pull request
Sep 4, 2020
* Bump ts-loader from 4.5.0 to 6.0.1 Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 4.5.0 to 6.0.1. - [Release notes](https://github.com/TypeStrong/ts-loader/releases) - [Changelog](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md) - [Commits](TypeStrong/ts-loader@v4.5.0...v6.0.1) Signed-off-by: dependabot[bot] <[email protected]> * Fix out declaration output path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generated protobuf typings extend jspb.Message to expose methods, add missing parameters and static methods.
Example:
https://github.com/shaxbee/grpc-web-dts-example/blob/master/typings-extend-jspb-message/example/example_pb.d.ts
Resolves #442