Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Messages in typings extending jspb.Message #444

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

shaxbee
Copy link
Contributor

@shaxbee shaxbee commented Jan 25, 2019

In generated protobuf typings extend jspb.Message to expose methods, add missing parameters and static methods.

Example:
https://github.com/shaxbee/grpc-web-dts-example/blob/master/typings-extend-jspb-message/example/example_pb.d.ts

Resolves #442

@jmzwcn
Copy link

jmzwcn commented Jan 25, 2019

great!

@shaxbee
Copy link
Contributor Author

shaxbee commented Jan 29, 2019

@stanley-cheung Added @types/google-protobuf and checked with docker-compose up --build that it builds and runs now.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@stanley-cheung stanley-cheung merged commit edb21bf into grpc:master Jan 30, 2019
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
* Bump ts-loader from 4.5.0 to 6.0.1

Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 4.5.0 to 6.0.1.
- [Release notes](https://github.com/TypeStrong/ts-loader/releases)
- [Changelog](https://github.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/ts-loader@v4.5.0...v6.0.1)

Signed-off-by: dependabot[bot] <[email protected]>

* Fix out declaration output path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] Include "extends Message" on generated classes in .d.ts files
5 participants