-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typescript definition for Oneof fields #460
Conversation
Sorry for the late look at this. There had been some work to re-sync this repo with our internal codebase so it looks like there are some new conflicts. Can you please resolve them and rebase to the latest master please? Thanks |
Just resolved conflicts, and rebased to latest master. Please let me know if there is any issue in the change. |
Ah, sorry, some more conflicts after a merge. Please rebase again. This PR will be next. |
Just resolved conflicts, and rebased again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions!
I have a weird side effect of this: it seems the getLogicfield(): LogicfieldTemplateItem | undefined;
setLogicfield(value?: LogicfieldTemplateItem): void;
hasLogicfield(): boolean;
clearLogicfield(): void;
hasLogicfield(): boolean;
getItemCase(): TemplateItem.ItemCase; |
Sorry. I didn't noticed that this method has be defined during resolving conflicts: https://github.com/grpc/grpc-web/blob/master/javascript/net/grpc/web/grpc_generator.cc#L863 submitted PR #519 to fix this issue. |
ATT