Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator] Move options parsing into dedicated class #764

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Mar 25, 2020

*** Note: There is no behavior change from this patch. ***

@stanley-cheung
Copy link
Collaborator

Thanks for the contribution. Yes this refactoring looks good. There's some test failure, PTAL, thanks

g++ -std=c++11 -I/usr/local/include -pthread  -c -o grpc_generator.o grpc_generator.cc
grpc_generator.cc: In member function 'virtual bool grpc::web::{anonymous}::GrpcCodeGenerator::Generate(const google::protobuf::FileDescriptor*, const string&, google::protobuf::compiler::GeneratorContext*, std::__cxx11::string*) const':
grpc_generator.cc:1534:41: error: 'class grpc::web::{anonymous}::GeneratorOptions' has no member named 'file_name'; did you mean 'file_name_'?
         context->Open(generator_options.file_name(file->name())));
                                         ^~~~~~~~~
make[1]: *** [grpc_generator.o] Error 1
<builtin>: recipe for target 'grpc_generator.o' failed
make[1]: Leaving directory '/github/grpc-web/javascript/net/grpc/web'
Makefile:101: recipe for target 'install-plugin' failed

@Yannic
Copy link
Contributor Author

Yannic commented Apr 2, 2020

Looks like I didn't add everything to the commit. Sorry about that!
ptal, thanks!

mode_(""),
import_style_(ImportStyle::CLOSURE),
generate_dts_(false),
multiple_files_(false){};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: our internal c++ linter doesn't like this ; after a }. Please remove it. Thanks!

@Yannic
Copy link
Contributor Author

Yannic commented Apr 3, 2020

Thanks, done!

@stanley-cheung stanley-cheung merged commit 1bcdae5 into grpc:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants