[generator] Refactor dependency management #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes intended.
Yannic
force-pushed
the
refactor_collect_deps
branch
from
9c9072b
to
e62abdb
Compare
|
Rebased after #879 |
|
Um... The interop test failure was quite oddly specific - running the interop tests against Envoy passed, but running the interop tests against our WIP Java in-process proxy failed. This change seems to be unrelated to that. I can help looking into this tomorrow. [Edit:] I am seeing the same error, in regular tests runs against [Edit2:] Ran the tests again and they passed. So I will track the flaky interop tests separately. Running presubmit tests internally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes intended.